Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ndt_scan_matcher): added a new parameter "n_startup_trials" #602

Conversation

SakodaShintaro
Copy link
Contributor

Description

Added a new parameter "n_startup_trials"

see autowarefoundation/autoware.universe#5078

Tests performed

see autowarefoundation/autoware.universe#5078

Effects on system behavior

see autowarefoundation/autoware.universe#5078

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@SakodaShintaro SakodaShintaro self-assigned this Sep 28, 2023
@SakodaShintaro SakodaShintaro changed the title Added a new parameter "n_startup_trials" feat(ndt_scan_matcher): added a new parameter "n_startup_trials" Sep 28, 2023
@SakodaShintaro SakodaShintaro marked this pull request as ready for review September 28, 2023 09:22
@KYabuuchi KYabuuchi self-requested a review October 13, 2023 04:21
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating the PR. LGTM

@SakodaShintaro SakodaShintaro merged commit eeccf72 into autowarefoundation:main Oct 13, 2023
7 of 9 checks passed
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
* feat: use xml for system monitor launch

Signed-off-by: Daisuke Nishimatsu <[email protected]>

* ci(pre-commit): autofix

* fix voltage monitor param path

Signed-off-by: Daisuke Nishimatsu <[email protected]>

Signed-off-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
soblin added a commit to soblin/autoware_launch that referenced this pull request Nov 18, 2023
…#602)

* intersection自動化に伴うパラメーター更新

Signed-off-by: Mamoru Sobue <[email protected]>

* Update autoware_launch/config/planning/scenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/intersection.param.yaml

---------

Signed-off-by: Mamoru Sobue <[email protected]>
Co-authored-by: Takeshi Miura <[email protected]>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware_launch that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants